PHPLIB-930: Update expected error in fle2-InsertFind-Unindexed test #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 1, 2022
tests/SpecTests/client-side-encryption/tests/fle2-InsertFind-Unindexed.json
Outdated
Show resolved
Hide resolved
|
Please remove "https://jira.mongodb.org/browse/PHPLIB-930" from the commit message. I only drop that in the PR descriptions because GitHub sometimes fails to render the configured autolinking. The commit itself only needs the issue number as a prefix, though. And friendly reminder to bump the status of PHPLIB-930 after opening a PR. |
levon80999
force-pushed
the
PHPLIB-930
branch
3 times, most recently
from
6f2636a to
80db9f2
Compare
jmikola
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Diff looks fine now, but I see the following is now missing from the commit:
Synced with mongodb/specifications@1a911b5e8911f6f57426ec1d451dbdc19480afd8
Please make sure that ends up in the final commit when merging. I see you missed it when merging #963.
levon80999
force-pushed
the
PHPLIB-930
branch
from
80db9f2 to
76dd6d4
Compare
levon80999
added a commit
to levon80999/mongo-php-library
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-930
Synced with mongodb/specifications@1a911b5